Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dagster-azure package #2483

Merged
merged 24 commits into from
Jun 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4742729
Add dagster-azure package with various storage components
sd2k May 19, 2020
21cbe6e
Rename Fake Azure classes and modules to more English-friendly names
sd2k May 21, 2020
7b3fa44
Add ADLS2Resource to wrap ADLS2/Blob clients
sd2k May 21, 2020
bab4fd8
Fix import order in dagster-azure
sd2k May 22, 2020
d179eef
Add dagster-azure to install_dev_python_modules make target
sd2k May 22, 2020
af9f486
Include azure-storage-blob in dagster-azure requirements
sd2k May 22, 2020
1f44d49
Remove unused variable in tests
sd2k May 24, 2020
42998a6
Don't install dagster-azure as part of install_dev_python_modules mak…
sd2k May 28, 2020
9a84309
Remove accidentally committed Azure Blob object/intermediate store im…
sd2k May 28, 2020
d9cd253
Wrap potentially incompatible imports to add a custom warning
sd2k May 28, 2020
ff2f81a
Add README to dagster-azure and note about incompatibility to dagster…
sd2k May 28, 2020
ddb9c3d
Isort
sd2k Jun 2, 2020
c8e068b
Set buildkite container for dagster-azure tests
Jun 2, 2020
dd608ea
Merge pull request #1 from dagster-io/dagster-azure
sd2k Jun 2, 2020
716d265
Env variables in buildkite for Azure
Jun 2, 2020
bc07898
Add dagster-azure package with various storage components
Jun 2, 2020
a870f80
more buildkite
Jun 3, 2020
6c6da60
tox
Jun 3, 2020
49b4030
Run black on dagster_snowflake
sd2k Jun 3, 2020
3cda8b6
Add pylint to dagster-azure tox.ini
sd2k Jun 3, 2020
3e8d8af
Explicitly specify __all__ for dagster_azure utils modules
sd2k Jun 3, 2020
8444f33
Merge pull request #2 from dagster-io/azure-env
sd2k Jun 3, 2020
96f08b1
Fix black issues
sd2k Jun 3, 2020
9cbe6a7
Merge branch 'master' into dagster-azure
sryza Jun 3, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .buildkite/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ def postgres_extra_cmds_fn(_):
# See: https://github.com/dagster-io/dagster/issues/1960
supported_pythons=SupportedPythonsNo38,
),
ModuleBuildSpec(
'python_modules/libraries/dagster-azure',
env_vars=['AZURE_STORAGE_ACCOUNT_KEY'],
),
ModuleBuildSpec(
'python_modules/libraries/dagster-celery',
env_vars=['AWS_ACCOUNT_ID', 'AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY'],
Expand Down
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ install_dev_python_modules:
-e examples[full] \
-r scala_modules/scripts/requirements.txt $(QUIET)

# Don't install dagster-azure as part of this target _yet_ - it has a dependency
# conflict with dagster-snowflake which causes any import of dagster-snowflake to
# fail with an ImportError (e.g. in examples).
# Uncomment only when snowflake-connector-python can be installed with optional (or compatible)
# Azure dependencies.
# See https://github.com/dagster-io/dagster/pull/2483#issuecomment-635174157
# pip install -e python_modules/libraries/dagster-azure $(QUIET)

set SLUGIFY_USES_TEXT_UNIDECODE=yes
pip install -e python_modules/libraries/dagster-airflow $(QUIET)

Expand Down
2 changes: 2 additions & 0 deletions python_modules/libraries/dagster-azure/.coveragerc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[run]
branch = True
201 changes: 201 additions & 0 deletions python_modules/libraries/dagster-azure/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "{}"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright {yyyy} {name of copyright owner}

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
5 changes: 5 additions & 0 deletions python_modules/libraries/dagster-azure/MANIFEST.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
recursive-include dagster_azure *.sh
recursive-include dagster_azure *.yaml
recursive-include dagster_azure *.txt
recursive-include dagster_azure *.template
include LICENSE
13 changes: 13 additions & 0 deletions python_modules/libraries/dagster-azure/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# dagster-azure

Utilities for using Azure Storage Accounts with Dagster. This is mostly aimed at Azure Data Lake Storage Gen 2 (ADLS2) but also contains some utilities for Azure Blob Storage.

**This package is incompatible with dagster-snowflake!** This is due to a version mismatch between the underlying azure-storage-blob package (dagster-snowflake has a transitive dependency on an old version, via snowflake-connector-python).

## Utilities

- ADLS2 file cache (see the `dagster_azure.adls2.adls2_file_cache` resource)
- The `dagster_azure.adls2.adls2_resource` providing solids access to an ADLS2 client
- Persistent storage using ADLS2 (see `dagster_azure.adls2.adls2_system_storage`)
- Log management using Azure Blob Storage (also compatible with ADLS - see `dagster_azure.blob.AzureBlobComputeLogManager`
- Fake clients for use in tests (see `dagster_azure.adls2.FakeADLS2Resource`)
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from dagster.core.utils import check_dagster_package_version

from .version import __version__

check_dagster_package_version('dagster-azure', __version__)
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from .fake_adls2_resource import FakeADLS2Resource, FakeADLS2ServiceClient
from .file_cache import ADLS2FileCache, adls2_file_cache
from .file_manager import ADLS2FileHandle, ADLS2FileManager
from .intermediate_store import ADLS2IntermediateStore
from .object_store import ADLS2ObjectStore
from .resources import adls2_resource
from .system_storage import adls2_plus_default_storage_defs, adls2_system_storage
from .utils import create_adls2_client

# from .solids import ADLS2Coordinate, file_handle_to_adls2
Loading