[ui] Some changes to icon types for Plus #24471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
hellendag
force-pushed
the
dish/insights-icons
branch
from
2d368b7 to
56c664b
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 1d21bbd. |
[INTERNAL_BRANCH=dish/fe-552-custom-rbac-confirmation-dialog-for-saving-edits]
hellendag
force-pushed
the
dish/insights-icons
branch
from
56c664b to
1d21bbd
Compare
salazarm
approved these changes
Sep 13, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Made a few changes to how the types are defined for insights icons to try to add a bit more strictness.
Counterpart to https://github.com/dagster-io/internal/pull/11507.
How I Tested These Changes
TS in both internal and OSS.
Changelog
NOCHANGELOG