[embedded-elt][sling] passing translator and replication config from decorator using metadata #20564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedramNavid
reviewed
Mar 21, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Show resolved
Hide resolved
cmpadden
force-pushed
the
colton/sling-example-metadata-passing
branch
from
48b4026 to
df8a236
Compare
cmpadden
commented
Mar 21, 2024
Comment on lines
13
to
20
| @sling_assets( | ||
| replication_config=replication_config, | ||
| dagster_sling_translator=DagsterSlingTranslator(), | ||
| ) | ||
| def my_assets(context, sling: SlingResource): | ||
| yield from sling.replicate( | ||
| context=context, | ||
| replication_config=replication_config, |
There was a problem hiding this comment.
@PedramNavid , while updating the examples I realized that replication_config also requires two definitions. I can take a stab at applying the same treatment here.
I also noticed that in all of the examples we showed passing the translator in the replicate call. Hopefully moving it to the decorator isn't too burdensome for the users.
There was a problem hiding this comment.
I've done the same thing with replication_config in this commit: 26f4e14
cmpadden
changed the title
rexledesma
suggested changes
Mar 21, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit dd973ae. |
rexledesma
reviewed
Mar 21, 2024
js_modules/dagster-ui/packages/ui-core/src/metadata/MetadataEntry.tsx
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
rexledesma
reviewed
Mar 21, 2024
...on_modules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/test_asset_decorator.py
Outdated
Show resolved
Hide resolved
|
Great feedback, per usual @rexledesma - updated the PR. (767459c) |
cmpadden
force-pushed
the
colton/sling-example-metadata-passing
branch
from
28e303f to
767459c
Compare
rexledesma
suggested changes
Mar 21, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
...on_modules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/test_asset_decorator.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/test_op.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/asset_decorator.py
Outdated
Show resolved
Hide resolved
cmpadden
commented
Mar 22, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
cmpadden
commented
Mar 22, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/test_op.py
Outdated
Show resolved
Hide resolved
rexledesma
approved these changes
Mar 22, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/sling/resources.py
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/test_op.py
Outdated
Show resolved
Hide resolved
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
…decorator using metadata (#20564) ## Summary & Motivation The current implementation of the Sling integration requires passing the _DagsterSlingTranslator_ and replication config to both the `@sling_assets` decorator, and the `replicate` method in the function body. Following the approach of `dagster-dbt` and the soon-to-be _dlt_ integration. this pull request demonstrates how we can pass the translator to the `replicate` method through the use of metadata. This workaround leads to a more intuitive end-user experience, albeit with more complex implementation. The negative to this approach is that the _translator_ and _replication-config_ remain on the metadata, see the modified unit test. ## How I Tested These Changes Ran unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The current implementation of the Sling integration requires passing the DagsterSlingTranslator and replication config to both the
@sling_assetsdecorator, and thereplicatemethod in the function body.Following the approach of
dagster-dbtand the soon-to-be dlt integration. this pull request demonstrates how we can pass the translator to thereplicatemethod through the use of metadata. This workaround leads to a more intuitive end-user experience, albeit with more complex implementation.The negative to this approach is that the translator and replication-config remain on the metadata, see the modified unit test.
How I Tested These Changes
Ran unit tests.