Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AssetSelection subclasses from NamedTuples to Pydantic #19197

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f476642
Convert NamedTuples to dataclasses in asset_selection.py
maximearmstrong Jan 12, 2024
a2276f3
Use dataclasses.replace over NamedTuple._replace in asset_selection.py
maximearmstrong Jan 12, 2024
74a437b
Lint
maximearmstrong Jan 12, 2024
a138fee
Use pydantic.dataclasses
maximearmstrong Jan 12, 2024
b1b6a5b
Lint
maximearmstrong Jan 12, 2024
83375ab
Revert to dataclasses
maximearmstrong Jan 12, 2024
21048ea
Merge branch 'master' into maxime/convert-assetselection-subclasses-f…
maximearmstrong Jan 16, 2024
5f15a5b
Use pydantic BaseModel instead of dataclass
maximearmstrong Jan 16, 2024
d2c22a9
Add copy and model_copy wrapper
maximearmstrong Jan 16, 2024
ebf6a2f
Lint
maximearmstrong Jan 16, 2024
fbea8b3
Fix tests
maximearmstrong Jan 16, 2024
c26b397
Lint
maximearmstrong Jan 16, 2024
3d44336
Refactor asset_selection.py
maximearmstrong Jan 17, 2024
1a80bda
Fix tests
maximearmstrong Jan 17, 2024
7783b98
Lint
maximearmstrong Jan 17, 2024
cddd052
Fix replace wrapper
maximearmstrong Jan 17, 2024
de034f6
Fix frozen inheritance in asset_selection
maximearmstrong Jan 17, 2024
62e0333
Replace frozen by allow_mutation
maximearmstrong Jan 17, 2024
a608685
Lint
maximearmstrong Jan 17, 2024
34554cf
Remove allow_mutation
maximearmstrong Jan 17, 2024
2435b63
Make AssetSelection and all subclasses frozen
maximearmstrong Jan 17, 2024
8751780
Lint
maximearmstrong Jan 17, 2024
37aea77
Use kwargs for replace in AssetSelection
maximearmstrong Jan 24, 2024
b9db7f0
Add type checking tests for asset selection subclasses
maximearmstrong Jan 24, 2024
e48d401
Merge branch 'master' into maxime/convert-assetselection-subclasses-f…
maximearmstrong Jan 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading