Show clearer grpc errors, as well as a custom failure for sensor timeouts in particular since those are so common #11576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
rexledesma
approved these changes
Jan 9, 2023
| if e.code() == grpc.StatusCode.DEADLINE_EXCEEDED: | ||
| raise DagsterUserCodeUnreachableError( | ||
| custom_timeout_message | ||
| or f"User code query timed out due to taking longer than {timeout} seconds to complete." |
There was a problem hiding this comment.
nit: user code -> code location server
Suggested change
| or f"User code query timed out due to taking longer than {timeout} seconds to complete." | |
| or f"The query to the code location server timed out due to taking longer than {timeout} seconds to complete." |
…outs in particular since those are so common Summary: - surface the error code instead of burying it in the nested cause error - for timeouts, include the original timeout (and that it timed out) - For sensors, include how you might fix it
AlexanderVR
pushed a commit
to AlexanderVR/dagster
that referenced
this pull request
Jan 10, 2023
…outs in particular since those are so common (dagster-io#11576) Summary: - surface the error code instead of burying it in the nested cause error - for timeouts, include the original timeout (and that it timed out) - For sensors, include how you might fix it ### Summary & Motivation ### How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary & Motivation
How I Tested These Changes