Add create_repository_using_definitions_args #11141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Created using spr 1.3.4 [skip ci]
sryza
approved these changes
Dec 15, 2022
Created using spr 1.3.4 [skip ci]
schrockn
changed the base branch from
schrockn/master.add-create_repository_using_definitions_args
to
master
schrockn
deleted the
schrockn/add-create_repository_using_definitions_args
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation: Based on writing the README/announcement for Definitions, I'm anticipating requests from existing users to create named repositories but using the typed APIs and resource manipulations of Definitions. Adding create_repository_using_definitions_args which can be used for that purpose.
Also added an extensive test case for the executor and logger behaviors on all the various permutations of jobs to ensure that executors and loggers are assigned properly.
Test Plan: BK