Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert-examples-repo-to-defs cloud nux quickstart_gcp #11136

Conversation

yuhan
Copy link
Contributor

@yuhan yuhan commented Dec 14, 2022

Summary & Motivation

convert quickstart_gcp example after it's moved from a standalone repo back to the mono repo (#11131)

  • workspace.yaml -> pyproject.toml
  • @repository -> Definitions
  • repository.py -> __init__.py

How I Tested These Changes

  • local dagit loads
  • unit

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
dagit-storybook ⬜️ Ignored (Inspect) Dec 15, 2022 at 2:16AM (UTC)
dagster ⬜️ Ignored (Inspect) Dec 15, 2022 at 2:16AM (UTC)

@yuhan yuhan force-pushed the yuhan/12-14-convert-examples-repo-to-defs_cloud_nux_quickstart_aws branch from 6a45bac to e13fcd0 Compare December 15, 2022 01:47
@yuhan yuhan force-pushed the yuhan/12-14-convert-examples-repo-to-defs_cloud_nux_quickstart_gcp branch from a5f8578 to e1946c5 Compare December 15, 2022 01:47
@yuhan yuhan requested review from schrockn and sryza December 15, 2022 01:51
@yuhan yuhan force-pushed the yuhan/12-14-convert-examples-repo-to-defs_cloud_nux_quickstart_aws branch from e13fcd0 to 064c730 Compare December 15, 2022 02:16
@yuhan yuhan force-pushed the yuhan/12-14-convert-examples-repo-to-defs_cloud_nux_quickstart_gcp branch from e1946c5 to 6a2065f Compare December 15, 2022 02:16
Base automatically changed from yuhan/12-14-convert-examples-repo-to-defs_cloud_nux_quickstart_aws to master December 15, 2022 04:32
@yuhan
Copy link
Contributor Author

yuhan commented Dec 15, 2022

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: gY2QLTjNrPJtUd2KNqDS

@yuhan yuhan merged commit 2169bf8 into master Dec 15, 2022
@yuhan yuhan deleted the yuhan/12-14-convert-examples-repo-to-defs_cloud_nux_quickstart_gcp branch December 15, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants