Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import error in IOManager docs #3573

Closed
catherinewu opened this issue Jan 22, 2021 · 3 comments
Closed

import error in IOManager docs #3573

catherinewu opened this issue Jan 22, 2021 · 3 comments
Assignees
Labels
area: io-manager Related to I/O Managers type: bug Something isn't working type: good first issue Good for newcomers

Comments

@catherinewu
Copy link
Contributor

catherinewu commented Jan 22, 2021

Summary

Screen Shot 2021-01-21 at 9 40 39 PM

https://docs.dagster.io/overview/io-managers/io-managers

Reproduction

Dagit UI/UX Issue Screenshots

Additional Info about Your Environment


Message from the maintainers:

Impacted by this bug? Give it a 👍. We factor engagement into prioritization.

@catherinewu catherinewu added type: bug Something isn't working type: good first issue Good for newcomers docs:content-overview labels Jan 22, 2021
@sryza
Copy link
Contributor

sryza commented Jan 22, 2021

I suspect the cause of this is that azure and snowflake have a dependency conflict, so, in dev setups, we avoid installing both of them at the same time. We typically install snowflake, not azure. Presumably, wherever these docs were built, this was the case.

This is reflected in the fact that https://docs.dagster.io/_apidocs/libraries/dagster_azure is empty.

@yuhan or @helloworld - do you have thoughts on what the right approach is here?

@nancydyc nancydyc added the area: io-manager Related to I/O Managers label Jan 22, 2021
@yuhan
Copy link
Contributor

yuhan commented Jan 22, 2021

yes, @sryza you are right. i think the solution is when deploying the docs site, the env should have installed all the packages listed in the api docs. i manually fixed it for 0.10.0 by pip install dagster-azure locally when i was the one deploying, but this isn't scalable. will figure out a way to address it soon

@yuhan yuhan self-assigned this Jan 27, 2021
yuhan added a commit that referenced this issue Feb 2, 2021
Summary:
#3573

#2483 (comment)

Test Plan:
in fresh virtualenv
```
~/dev/dagster arcpatch-D6207
$ make dev_install

~/dev/dagster arcpatch-D6207
$ test-D6207 $ pip freeze | grep azure
azure-common==1.1.26
azure-core==1.10.0
azure-storage-blob==12.3.2
azure-storage-file-datalake==12.0.2
-e [email protected]:dagster-io/dagster.git@bd35c74ff476078799a55650d70fa5c28b43d373#egg=dagster_azure&subdirectory=python_modules/libraries/dagster-azure

~/dev/dagster/docs arcpatch-D6207
test-D6207 $ make buildnext && cd next && yarn && yarn dev
```
{F536160}

Reviewers: sashank, nate, sandyryza

Reviewed By: nate, sandyryza

Differential Revision: https://dagster.phacility.com/D6207
@yuhan
Copy link
Contributor

yuhan commented Feb 2, 2021

this should be resolved by https://dagster.phacility.com/D6246 because the docs build process will have its own requirements

@yuhan yuhan closed this as completed Feb 2, 2021
mrdavidlaing pushed a commit to mrdavidlaing/dagster that referenced this issue Feb 20, 2021
Summary:
dagster-io#3573

dagster-io#2483 (comment)

Test Plan:
in fresh virtualenv
```
~/dev/dagster arcpatch-D6207
$ make dev_install

~/dev/dagster arcpatch-D6207
$ test-D6207 $ pip freeze | grep azure
azure-common==1.1.26
azure-core==1.10.0
azure-storage-blob==12.3.2
azure-storage-file-datalake==12.0.2
-e [email protected]:dagster-io/dagster.git@bd35c74ff476078799a55650d70fa5c28b43d373#egg=dagster_azure&subdirectory=python_modules/libraries/dagster-azure

~/dev/dagster/docs arcpatch-D6207
test-D6207 $ make buildnext && cd next && yarn && yarn dev
```
{F536160}

Reviewers: sashank, nate, sandyryza

Reviewed By: nate, sandyryza

Differential Revision: https://dagster.phacility.com/D6207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: io-manager Related to I/O Managers type: bug Something isn't working type: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants