Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hint to point users to autocomplete in config editor #1576

Closed
mgasner opened this issue Jul 17, 2019 · 2 comments
Closed

Add a hint to point users to autocomplete in config editor #1576

mgasner opened this issue Jul 17, 2019 · 2 comments
Assignees
@bengotow

Comments

@mgasner
Copy link
Contributor

mgasner commented Jul 17, 2019 •
edited
Loading

@Eronarn

I tried using the auto completion features here, rather than just pasting in the YAML dictionary. This worked fine, except in the case where I was entering a new dict and hadn't typed anything yet. I would've expected a way to see the available fields for that dict without having to first type a character (like popping up automatically before I hit tab).
@mgasner mgasner added the dagit label Jul 17, 2019
@mgasner mgasner added this to the 0.5.5 milestone Jul 25, 2019
@schrockn schrockn removed this from the 0.6.0 milestone Sep 4, 2019
@bengotow
Copy link
Collaborator

Addressed in https://dagster.phacility.com/D1509!

bengotow added a commit that referenced this issue Nov 29, 2019
@bengotow
Show autocompletions in initial empty config state, mention Ctrl-Space (
ed957b2 
#1576)

Summary: This diff 1) makes it so that the config schema panel appears on brand new Config Editor tabs (previously you had to type a character of a valid key and then it would appear.) and #2) adds a small note to the schema panel that says "Ctrl+Space to show auto-completions inline." There may be better messaging for this but I think knowing that shortcut exists is a game changer and we should get it in ASAP.

Test Plan: Updated snapshots

Reviewers: #ft, schrockn

Reviewed By: #ft, schrockn

Subscribers: schrockn

Differential Revision: https://dagster.phacility.com/D1509
@bengotow
Copy link
Collaborator

Resolved by D1509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bengotow bengotow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgasner @bengotow @schrockn