comment

dagster-io · Aug 20, 2024 · b088121 · b088121
1 parent 2ed0dab
commit b088121
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/python_modules/dagster-graphql/dagster_graphql/schema/backfill.py b/python_modules/dagster-graphql/dagster_graphql/schema/backfill.py
@@ -506,13 +506,14 @@ def resolve_runStatus(self, _graphene_info: ResolveInfo) -> str:
                 return GrapheneRunStatus.QUEUED
             return GrapheneRunStatus.STARTED
         # BulkActionStatus.COMPLETED
+        # Backfills are only marked as COMPLETED once all runs that are part of the backfill have reached
+        # a finished state (SUCCESS, FAILURE, or CANCELED). So we only need to check for those
+        # statuses to determine the overall status of the backfill.
         sub_runs = self._get_records(_graphene_info)
         sub_run_statuses = [record.dagster_run.status.value for record in sub_runs]
         if all(status == "SUCCESS" for status in sub_run_statuses):
             return GrapheneRunStatus.SUCCESS
-        if any(status == "FAILURE" for status in sub_run_statuses):
-            return GrapheneRunStatus.FAILURE
-        if any(status == "CANCELED" for status in sub_run_statuses):
+        if any(status == "FAILURE" or status == "CANCELED" for status in sub_run_statuses):
             return GrapheneRunStatus.FAILURE
 
         # can't import this because two deserializers get registered for PipelineRunStatsSnapshot