Skip to content

Commit

Permalink
Switch dagster_webserver and dagster_gcp_pyspark to hyphens (#18902)
Browse files Browse the repository at this point in the history
Open questions:

- ~~why did tests start failing this weekend? (best guess is setuptools
69.03 on Dec 23rd)~~
- ~~why does this fix the failures?~~
- would this be a breaking change? I'm hopeful that it's not, because
the package is already published as dagster-webserver
https://pypi.org/project/dagster-webserver/

Edit: the first two are answered by
pypa/setuptools#2522 (comment):
setuptools change how they handle hyphens vs underscores

This makes the two required changes to get the build green (these two
are special because of the underscore packages, they're the ones that
are relied on in tests). In general we should make it a pattern to make
package names use hyphens and match their directory name to avoid
confusion.
  • Loading branch information
johannkm authored Dec 27, 2023
1 parent 9d0ceee commit af7b67e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion python_modules/dagster-webserver/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def get_version():
# dont pin dev installs to avoid pip dep resolver issues
pin = "" if ver == "1!0+dev" else f"=={ver}"
setup(
name="dagster_webserver",
name="dagster-webserver",
version=ver,
author="Dagster Labs",
author_email="[email protected]",
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-gcp-pyspark/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def get_version() -> str:
# dont pin dev installs to avoid pip dep resolver issues
pin = "" if ver == "1!0+dev" else f"=={ver}"
setup(
name="dagster_gcp_pyspark",
name="dagster-gcp-pyspark",
version=get_version(),
author="Dagster Labs",
author_email="[email protected]",
Expand Down

0 comments on commit af7b67e

Please sign in to comment.