Skip to content

Commit

Permalink
Handle op outputs in default asset IO manager (#8074)
Browse files Browse the repository at this point in the history
  • Loading branch information
clairelin135 authored May 31, 2022
1 parent 8551940 commit 6b8f907
Show file tree
Hide file tree
Showing 19 changed files with 724 additions and 1,131 deletions.
2 changes: 1 addition & 1 deletion docs/content/api/modules.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/content/api/searchindex.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/content/api/sections.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions docs/content/concepts/assets/software-defined-assets.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ Different assets can have different IO managers:
```python file=/concepts/assets/asset_different_io_managers.py startafter=start_marker endbefore=end_marker
from dagster_aws.s3 import s3_pickle_asset_io_manager, s3_resource

from dagster import AssetGroup, asset, fs_asset_io_manager
from dagster import AssetGroup, asset, fs_io_manager


@asset(io_manager_key="s3_io_manager")
Expand All @@ -225,7 +225,7 @@ asset_group = AssetGroup(
resource_defs={
"s3_io_manager": s3_pickle_asset_io_manager,
"s3": s3_resource,
"fs_io_manager": fs_asset_io_manager,
"fs_io_manager": fs_io_manager,
},
)
```
Expand All @@ -237,7 +237,7 @@ The same assets can be bound to different resources and IO managers in different
```python file=/concepts/assets/asset_io_manager_prod_local.py startafter=start_marker endbefore=end_marker
from dagster_aws.s3 import s3_pickle_asset_io_manager, s3_resource

from dagster import AssetGroup, asset, fs_asset_io_manager
from dagster import AssetGroup, asset, fs_io_manager


@asset
Expand All @@ -257,7 +257,7 @@ prod_asset_group = AssetGroup(

local_asset_group = AssetGroup(
[upstream_asset, downstream_asset],
resource_defs={"io_manager": fs_asset_io_manager},
resource_defs={"io_manager": fs_io_manager},
)
```

Expand Down
Binary file modified docs/next/public/objects.inv
Binary file not shown.
3 changes: 0 additions & 3 deletions docs/sphinx/sections/api/apidocs/assets.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,3 @@ A software-defined asset combines:
.. autoclass:: AssetIn

.. autoclass:: SourceAsset

.. autoconfigurable:: fs_asset_io_manager
:annotation: IOManagerDefinition
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# start_marker
from dagster_aws.s3 import s3_pickle_asset_io_manager, s3_resource

from dagster import AssetGroup, asset, fs_asset_io_manager
from dagster import AssetGroup, asset, fs_io_manager


@asset(io_manager_key="s3_io_manager")
Expand All @@ -20,7 +20,7 @@ def downstream_asset(upstream_asset):
resource_defs={
"s3_io_manager": s3_pickle_asset_io_manager,
"s3": s3_resource,
"fs_io_manager": fs_asset_io_manager,
"fs_io_manager": fs_io_manager,
},
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# start_marker
from dagster_aws.s3 import s3_pickle_asset_io_manager, s3_resource

from dagster import AssetGroup, asset, fs_asset_io_manager
from dagster import AssetGroup, asset, fs_io_manager


@asset
Expand All @@ -22,7 +22,7 @@ def downstream_asset(upstream_asset):

local_asset_group = AssetGroup(
[upstream_asset, downstream_asset],
resource_defs={"io_manager": fs_asset_io_manager},
resource_defs={"io_manager": fs_io_manager},
)

# end_marker
Loading

1 comment on commit 6b8f907

@vercel
Copy link

@vercel vercel bot commented on 6b8f907 May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.