Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/hashicorp/go-retryablehttp from 0.7.5 to 0.7.7 #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on May 7, 2024

  1. Update README with description of dagger's use of this fork

    Signed-off-by: Erik Sipsma <[email protected]>
    sipsma committed May 7, 2024
    Configuration menu
    Copy the full SHA
    8e09b15 View commit details
    Browse the repository at this point in the history
  2. solver: prevent edge merge to inactive states

    Before this, it was possible for an edge merge to happen to a target
    edge/state that is no longer in the actives map, e.g.
    1. Job A solves some edges
    2. Job B solves some edges that get merged with job A's edges
    3. Job A is discarded
    4. Job C solves some edges that get merged with job B's edges, which
       recursively end up merging to job A's, which no longer exist in the
       actives map.
    
    While this doesn't always result in an error, given the right state and
    order of operations this can result in `getState` or `getEdge` being
    called on the "stale" edges that are inactive and an error. E.g. if a
    stale dep transitions from desired state `cache-fast` to `cache-slow`,
    the slow cache logic will call `getState` on it and return a `compute
    cache` error.
    
    I also *suspect* this is the same root cause behind `inconsistent graph
    state` errors still seen occasionally, but have not repro'd that error
    locally so can't be 100% sure yet.
    
    The fix here updates `state.setEdge` to register all the jobs in the
    source edge's state with the target edge's state. This works out
    because:
    1. edges that are the target of a merge will not have their state
       removed from the actives map if only the original job creating them
       is discarded
    1. those edges are still removed eventually, but only when all jobs
       referencing them (now including jobs referencing them via edge
       merges) are discarded
    
    Signed-off-by: Erik Sipsma <[email protected]>
    sipsma committed May 7, 2024
    Configuration menu
    Copy the full SHA
    56df2df View commit details
    Browse the repository at this point in the history
  3. solver: use logrus fields for more scheduler debug logs

    While debugging solver bugs with scheduler debug logs I ended up with so
    many logs that I needed to write a program that parsed them and
    extracted relevant information so it could be summarized more
    comprehensibly.
    
    That was greatly simplified by updating some of the old scheduler debug
    logs to use logrus fields rather than one-off `fmt.Sprintf`s. All the
    same information as before is present, just formatted more consistently
    for easier parsability.
    
    I also ended up removing one of the logs I recently added that printed
    each job for a vertex in `loadUnlocked`. I realized that information was
    parsable from the rest of the logs and thus was mostly just extra noise.
    
    Signed-off-by: Erik Sipsma <[email protected]>
    sipsma committed May 7, 2024
    Configuration menu
    Copy the full SHA
    447857f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    63352b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. build(deps): bump github.com/hashicorp/go-retryablehttp

    Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.5 to 0.7.7.
    - [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md)
    - [Commits](hashicorp/go-retryablehttp@v0.7.5...v0.7.7)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/hashicorp/go-retryablehttp
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3c511c4 View commit details
    Browse the repository at this point in the history