Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server groups #99

Closed
wants to merge 13 commits into from
Closed

Server groups #99

wants to merge 13 commits into from

Conversation

dollannn
Copy link
Contributor

Please give me opinions on this, this proposed schema allows one server to have many groups hence the extra table.
After review I will go ahead with the implementation.

@daffyyyy
Copy link
Owner

sa_server_to_group not needed i guess, just assign group_id in sa_servers table (add new column like group_id)

@dollannn
Copy link
Contributor Author

sa_server_to_group not needed i guess, just assign group_id in sa_servers table (add new column like group_id)

The reason why I opted for that is to allow one server to have many groups assigned to it. For example one group could encompass all the servers, while one group might target only retake. That seemed more beneficial to me as it becomes easier to add someone as a "moderator" on all servers etc

@daffyyyy
Copy link
Owner

Contributor

Then u can separate all id with comma for e.g. group_id => 1,3,6

@dollannn dollannn changed the title Proposed schema for server groups Server groups Apr 11, 2024
@dollannn
Copy link
Contributor Author

Needs some final testing and maybe minor improvements otherwise this should close #40

@daffyyyy daffyyyy added the invalid This doesn't seem right label Apr 18, 2024
@daffyyyy
Copy link
Owner

After reviewing the entire solution - I decided to not add it to the plugin.
I see a better way to make server groups and it will be done in the near future

@dollannn dollannn closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants