Better duration check

daffyyyy · Apr 24, 2024 · a0b2e59 · a0b2e59
1 parent fb251aa
commit a0b2e59
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/Commands/basebans.cs b/Commands/basebans.cs
@@ -382,16 +382,19 @@ private bool CheckValidBan(CCSPlayerController? caller, int duration)
 		{
 			bool validCaller = caller != null && caller.IsValid;
 
-			if (duration > Config.MaxBanDuration)
+			bool canPermBan = validCaller && AdminManager.PlayerHasPermissions(caller, "@css/permban");
+
+			if (duration > Config.MaxBanDuration && canPermBan == false)
 			{
 				if (validCaller)
 					caller.PrintToChat($"[Simple Admin] Ban duration cannot exceed {Config.MaxBanDuration} minutes.");
 				return false;
 			}
 
-			if (duration == 0 && validCaller && AdminManager.PlayerHasPermissions(caller, "@css/permban") == false)
+			if (duration == 0 && canPermBan == false)
 			{
-				caller.PrintToChat($"[Simple Admin] You do not have the right to permanently ban.");
+				if (validCaller)
+					caller.PrintToChat($"[Simple Admin] You do not have the right to permanently ban.");
 				return false;
 			}