ci(build.yml): add Linux package hooks #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyoki
previously approved these changes
Jun 17, 2023
piyoki
changed the title
chore: upgrade dae-wing (daeuniverse#41) ci: add a workflow to synchronize upstream repositories (daeuniverse#43) * ci: add a workflow to synchronize upstream dae-wing with workflow_dispatch * ci(sync): fix sync commit message * ci(sync): change name to Synchronize upstream Co-authored-by: Kevin Yu <[email protected]> * ci(sync): rename sync.yml to sync-upstream-source.yml * ci(sync): change name to Synchronize Upstream --------- Co-authored-by: Kevin Yu <[email protected]> ci(sync): input variables should be retrived from inputs ci(sync): should clone full history with fetch-depth: 0 ci(build.yml): fix upload to release
mzz2017
reviewed
Jun 17, 2023
Comment on lines
-28
to
-30
| FILE=./daed-full-src.zip | ||
| DGST=$FILE.dgst | ||
| md5sum $FILE >>$DGST | ||
| shasum -a 1 $FILE >>$DGST | ||
| shasum -a 256 $FILE >>$DGST | ||
| shasum -a 512 $FILE >>$DGST |
There was a problem hiding this comment.
Maybe you want to calculate all digests in one step, but I cannot see daed-full-src.zip.dgst. Something goes wrong?
There was a problem hiding this comment.
c3abeb8 does not fix up the problem daed-full-src.zip should not be zipped again.
There was a problem hiding this comment.
daed-full-src.zip is actually zipped by the Action workflow, and when upload it to Action artifacts, it will be zipped again as daed-full-src.zip.zip, so in the last release job, we should only generate the dgst file for it, but not zip it again like web files.
3 tasks
|
@MarksonHon Could you please resolve these conflicts? I've ready to merge it. |
kunish
approved these changes
Jun 17, 2023
mzz2017
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Systemd services should be reload after installation and removing, and daed should be stopped before removing.
Checklist
Full changelog
Issue reference
Fix #[issue number]