ci(Dockerfile): Dockerfile working out of box #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero-intelligent
changed the title
hero-intelligent
changed the title
piyoki
suggested changes
Sep 3, 2023
3 tasks
piyoki
changed the title
mzz2017
requested changes
Sep 3, 2023
Co-authored-by: kev <[email protected]> Signed-off-by: hero-intelligent <[email protected]>
Co-authored-by: kev <[email protected]> Signed-off-by: hero-intelligent <[email protected]>
Co-authored-by: kev <[email protected]> Signed-off-by: hero-intelligent <[email protected]>
|
Please have another review. @mzz2017 @yqlbu |
mzz2017
reviewed
Sep 3, 2023
|
The code quality is very good. I think we can consider merging after resolving a few minor issues. |
|
By the way, this is my first issue and PR that received developers' reply. I've learned a lot from this experience. Thanks for your recognition. Wish this project another great success. |
|
Awesome and unbelievable. Let's have a test for his product. @yqlbu @kunish |
piyoki
reviewed
Sep 3, 2023
piyoki
approved these changes
Sep 3, 2023
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR makes Dockerfile work out of box
see: #250 and #262
Checklist
Full Changelogs
level=fatal msg="dae.Run: load eBPF objects: field TproxyWanEgress: program tproxy_wan_egress: load program: argument list too long: ;: 1428: (71) r2 (truncated, 879 line(s) omitted)"#250)level=fatal msg="dae.Run: load eBPF objects: field TproxyWanEgress: program tproxy_wan_egress: load program: argument list too long: ;: 1428: (71) r2 (truncated, 879 line(s) omitted)"#250 (comment))Issue Reference
#250
#262
Test Result
works just fine