ci: build and publish daed docker image with geosite/geoip #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzz2017
reviewed
Jun 11, 2023
piyoki
suggested changes
Jun 11, 2023
Comment on lines
15
to
24
| - name: docker image - quay.io | ||
| uses: aevea/action-kaniko@master | ||
| with: | ||
| registry: quay.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.QUAY_PASS }} | ||
| image: ${{ github.repository }} | ||
| build_file: Dockerfile | ||
| tag_with_latest: true | ||
| cache: true | ||
| cache_registry: quay.io/${{ github.repository_owner }}/cache |
There was a problem hiding this comment.
Just a quick note: with this setup, Kaniko can ONLY build one arch-based image at a time.
There was a problem hiding this comment.
OK, noted, then github matrix is needed here
|
Also, consider adding a |
kunish
force-pushed
the
ci-publish-docker-image
branch
from
1cb67f8 to
364dcb3
Compare
piyoki
previously approved these changes
Jun 11, 2023
kunish
force-pushed
the
ci-publish-docker-image
branch
2 times, most recently
from
78fe6f1 to
7b2569c
Compare
kunish
force-pushed
the
ci-publish-docker-image
branch
from
7b2569c to
8907ce7
Compare
kunish
force-pushed
the
ci-publish-docker-image
branch
from
13cce45 to
ba98b22
Compare
kunish
force-pushed
the
ci-publish-docker-image
branch
from
ba98b22 to
700f2cc
Compare
kunish
force-pushed
the
ci-publish-docker-image
branch
from
a8e281e to
5ee071a
Compare
|
Last success run log: https://github.com/daeuniverse/daed/actions/runs/5252280018/jobs/9488146854 |
mzz2017
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a dedicated workflow file to support
build and publish daed docker image with geosite/geoipwithin github ciNote
Only build linux/amd64 for now