Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename modal not closing after changing rule names #188

Merged
merged 3 commits into from
Jul 26, 2023
Merged

fix: rename modal not closing after changing rule names #188

merged 3 commits into from
Jul 26, 2023

Conversation

kunish
Copy link
Member

@kunish kunish commented Jul 26, 2023 •
edited by piyoki
Loading

Background

This PR fixes an issue, rename modal not closing after changing rule names

Checklist

Full changelogs

  • fix: rename modal not closing after changing rule names
  • chore: upgrade dependencies

Issue reference

Closes #[issue number]

Test Result

@kunish kunish requested a review from a team as a code owner July 26, 2023 14:40
@kunish kunish requested a review from a team as a code owner July 26, 2023 14:41
@kunish kunish merged commit bfc7d3a into main Jul 26, 2023
@kunish kunish deleted the fix/rename-modal-not-closing branch July 26, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyoki piyoki piyoki approved these changes

Assignees

@kunish kunish

Labels
fix not-yet-tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunish @piyoki