Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(pr-build): ONLY keep arm64, amd64 as build targets #180

Merged
merged 7 commits into from
Jul 25, 2023
Merged

ci(pr-build): ONLY keep arm64, amd64 as build targets #180

merged 7 commits into from
Jul 25, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 21, 2023 •
edited
Loading

Background

As the title suggests. The idea is to drastically reduce build time.

Checklist

Full changelogs

  • ci(pr-build): ONLY keep arm64, amd64 as build targets
  • patch(friendly-filenames.json): add entry for amd64

Issue reference

NA

Test Result

image image

@piyoki piyoki requested a review from a team as a code owner July 21, 2023 10:57
@piyoki piyoki requested a review from MarksonHon July 21, 2023 10:57
dae-prow[bot]
dae-prow bot previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki requested a review from kunish July 21, 2023 14:16
mzz2017
mzz2017 requested changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should retain arm 5 6 7.

@piyoki
Copy link
Contributor Author

piyoki commented Jul 23, 2023

I think we should retain arm 5 6 7.

Why's that?

@mzz2017
Copy link
Contributor

mzz2017 commented Jul 24, 2023

Why's that?

Many users use them. And they are not slow in building.

@piyoki
Copy link
Contributor Author

piyoki commented Jul 24, 2023

Why's that?

Many users use them. And they are not slow in building.

Sure, I will add them back.

@piyoki piyoki requested a review from mzz2017 July 24, 2023 11:06
kunish
kunish requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check

mzz2017
mzz2017 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kunish kunish merged commit 8e8cb15 into main Jul 25, 2023
@kunish kunish deleted the pr_build_target branch July 25, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 approved these changes

@kunish kunish kunish approved these changes

@dae-prow dae-prow[bot] dae-prow[bot] left review comments

@MarksonHon MarksonHon Awaiting requested review from MarksonHon

Assignees

@piyoki piyoki

Labels
ci tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piyoki @mzz2017 @kunish