Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refine pr-build workflow #138

Merged
merged 5 commits into from
Jul 9, 2023
Merged

ci: refine pr-build workflow #138

merged 5 commits into from
Jul 9, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 9, 2023 •
edited
Loading

Background

Mimic proposed changes in daeuniverse/dae#183

Checklist

Full changelog

  • docs(getting-started): rename nightly build to pr-build
  • refactor(workflow): rename build-nightly -> pr-build
  • ci: add run_name followed by #pr_number - pr_title @pr_ref:pr_sha
  • ci: add initial job to show pr context
  • refactor(build): update workflow title from Build to Build (Stable)
  • ci: make context an independent job

Issue reference

NA

Test Result

https://github.com/daeuniverse/daed/actions/runs/5497492906

image

@piyoki piyoki requested a review from a team as a code owner July 9, 2023 02:08
@dae-prow dae-prow bot assigned piyoki Jul 9, 2023
dae-prow[bot]
dae-prow bot previously approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

kunish
kunish requested changes Jul 9, 2023
View reviewed changes
.github/workflows/pr-build.yml Outdated Show resolved Hide resolved
kunish
kunish approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks

@kunish kunish merged commit d337ea8 into main Jul 9, 2023
@kunish kunish deleted the pr_build branch July 9, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunish kunish kunish approved these changes

@dae-prow dae-prow[bot] dae-prow[bot] left review comments

Assignees

@piyoki piyoki

Labels
ci tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyoki @kunish