-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a configure node modal #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO:
|
❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you. |
kunish
force-pushed
the
configure-node-modal
branch
from
July 1, 2023 03:34
cd4c3d4
to
d8d4e8e
Compare
kunish
force-pushed
the
configure-node-modal
branch
from
July 1, 2023 12:25
1df3a1d
to
e18b5f0
Compare
kunish
force-pushed
the
configure-node-modal
branch
from
July 1, 2023 12:46
b1587e5
to
e7d30f2
Compare
kunish
force-pushed
the
configure-node-modal
branch
from
July 1, 2023 12:49
e7d30f2
to
5806d3c
Compare
kunish
force-pushed
the
configure-node-modal
branch
from
July 1, 2023 18:43
2c93e8e
to
459326e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Since the PR has been fully tested, please consider merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR adds a new feature, add a configure node modal to support generate proxy node share link on the fly. This can help user easily create or modify a node through the configure node modal form submission.
Checklist
Full changelog
Issue reference
None