Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a configure node modal #125

Merged
merged 22 commits into from
Jul 1, 2023
Merged

feat: add a configure node modal #125

merged 22 commits into from
Jul 1, 2023

Conversation

kunish
Copy link
Member

@kunish kunish commented Jun 28, 2023

Background

image

This PR adds a new feature, add a configure node modal to support generate proxy node share link on the fly. This can help user easily create or modify a node through the configure node modal form submission.

Checklist

Full changelog

  • feat: add a configure node modal
  • fix: correcting autoConfigKernelParameter zh-Hans translation
  • fix: reload after updating/removing subscription

Issue reference

None

@kunish kunish requested a review from a team as a code owner June 28, 2023 17:39
@kunish
Copy link
Member Author

kunish commented Jun 28, 2023

TODO:

  • add i18n locale translations
  • replace the onSubmit logic with real url generation
  • add a button for node creation and modification

@dae-prow
Copy link
Contributor

dae-prow bot commented Jun 29, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@kunish kunish force-pushed the configure-node-modal branch from cd4c3d4 to d8d4e8e Compare July 1, 2023 03:34
@kunish kunish marked this pull request as draft July 1, 2023 03:43
@kunish kunish requested a review from a team July 1, 2023 03:53
@kunish kunish marked this pull request as ready for review July 1, 2023 05:24
@kunish kunish force-pushed the configure-node-modal branch from 1df3a1d to e18b5f0 Compare July 1, 2023 12:25
@kunish kunish force-pushed the configure-node-modal branch from b1587e5 to e7d30f2 Compare July 1, 2023 12:46
@kunish kunish force-pushed the configure-node-modal branch from e7d30f2 to 5806d3c Compare July 1, 2023 12:49
@kunish kunish force-pushed the configure-node-modal branch from 2c93e8e to 459326e Compare July 1, 2023 18:43
@kunish kunish merged commit fa55f7c into main Jul 1, 2023
@kunish kunish deleted the configure-node-modal branch July 1, 2023 18:43
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants