Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dns): add docs for #649 #687

Merged
merged 6 commits into from
Nov 2, 2024
Merged

docs(dns): add docs for #649 #687

merged 6 commits into from
Nov 2, 2024

Conversation

EkkoG
Copy link
Contributor

@EkkoG EkkoG commented Nov 2, 2024

Background

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@EkkoG EkkoG requested review from a team as code owners November 2, 2024 03:19
@dae-prow dae-prow bot assigned EkkoG Nov 2, 2024
@dae-prow dae-prow bot added the documentation Improvements or additions to documentation label Nov 2, 2024
jschwinger233
jschwinger233 previously approved these changes Nov 2, 2024
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在 example.dae 加上所有支持的 upstream 但是不使用,另外在 dns docs 中给出支持的相关的 schema 链接(像支持的协议那样)

Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@mzz2017 mzz2017 merged commit 78f4e34 into daeuniverse:main Nov 2, 2024
3 checks passed
Copy link

@Mapleshade20 Mapleshade20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo “cusotm_path” in example.dae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants