feat: support assist connectivity check (udp-dns) by dns module #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and passed on soft routing (Linux 6.6.32 aarch64 GNU/Linux). Btw, thanks to mzz for this passionate weekend of coding. |
sumire88
approved these changes
Jun 16, 2024
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
This was referenced Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There were sporadic user reports in the past that
tcp+udpdid not work properly. I cannot reproduce this problem. One possibility is that the DNS server used for check connectivity is different from the actual DNS, and the dialer server has different connectivity quality (good/poor) to the two DNS servers.To solve this problem, this PR supports the DNS module to feedback query failures to the connectivity module, thereby assisting in connectivity checks and lowering node priority.
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result