Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump submodule dae_bpf_headers #487

Merged
merged 4 commits into from
Mar 30, 2024
Merged

chore: bump submodule dae_bpf_headers #487

merged 4 commits into from
Mar 30, 2024

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Mar 28, 2024 •
edited
Loading

Background

Update submodule to include daeuniverse/dae_bpf_headers#2

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #453

Test Result

@dae-prow dae-prow bot added the chore label Mar 28, 2024
@jschwinger233 jschwinger233 marked this pull request as ready for review March 28, 2024 08:12
@jschwinger233 jschwinger233 requested a review from a team as a code owner March 28, 2024 08:12
@jschwinger233
Copy link
Member Author

noiseless arm64 build seems to return: https://github.com/daeuniverse/dae/actions/runs/8464305264/job/23188739565?pr=487

@jschwinger233 jschwinger233 requested a review from mzz2017 March 28, 2024 08:27
sumire88
sumire88 previously approved these changes Mar 28, 2024
View reviewed changes
@sumire88 sumire88 requested a review from a team March 28, 2024 11:08
dae-prow[bot]
dae-prow bot previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@jschwinger233 jschwinger233 dismissed stale reviews from dae-prow[bot] and sumire88 via ad275c4 March 28, 2024 16:54
@jschwinger233 jschwinger233 requested a review from a team as a code owner March 28, 2024 17:06
@jschwinger233 jschwinger233 added the documentation Improvements or additions to documentation label Mar 28, 2024
mzz2017
mzz2017 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@mzz2017 mzz2017 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschwinger233 jschwinger233 merged commit 7aad3a9 into main Mar 30, 2024
31 checks passed
@jschwinger233 jschwinger233 deleted the gray/fix-arm-build branch March 30, 2024 06:34
This was referenced Mar 30, 2024
Merged
Closed
@dae-prow dae-prow bot mentioned this pull request Apr 15, 2024
Closed
@dae-prow dae-prow bot mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanlce wanlce wanlce approved these changes

@mzz2017 mzz2017 mzz2017 approved these changes

@sumire88 sumire88 sumire88 left review comments

@dae-prow dae-prow[bot] dae-prow[bot] left review comments

Assignees

@jschwinger233 jschwinger233

Labels
chore documentation Improvements or additions to documentation tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Unable to compile trace/trace.go for arm64
4 participants
@jschwinger233 @mzz2017 @wanlce @sumire88