Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reloading progress and error for dae reload #470

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Mar 7, 2024

Background

In the past, dae reload always returned OK. When the reload failed, we had no way of knowing what error occurred and could only obtain the failure information by viewing the dae log.

This PR supports dae reload to wait for the reloading progress and print error information when an error occurs.

Specifically, /var/run/dae.progress is introduced; dae will write its status to this file during the reloading process, thus dae reload can read the current reloading status of dae from this flie.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

image

@mzz2017 mzz2017 requested a review from a team as a code owner March 7, 2024 14:15
@mzz2017 mzz2017 changed the title feat: support reloading progress feat: support reloading progress for dae reload Mar 7, 2024
@mzz2017 mzz2017 changed the title feat: support reloading progress for dae reload feat: support reloading progress and error for dae reload Mar 7, 2024
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88 sumire88 merged commit b9741c9 into main Mar 27, 2024
30 checks passed
@sumire88 sumire88 deleted the mzz/feat_support_reload_progress branch March 27, 2024 05:01
@dae-prow dae-prow bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants