Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ci modules using nodejs to latest #465

Merged
merged 4 commits into from
Mar 2, 2024

Conversation

MarksonHon
Copy link
Contributor

@MarksonHon MarksonHon commented Mar 1, 2024

Background

Node.js 16 is no longer supported by GitHub, we need to update the corresponding modules to a version based on Node.js 20.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@MarksonHon MarksonHon requested a review from a team as a code owner March 1, 2024 12:30
sumire88
sumire88 previously approved these changes Mar 1, 2024
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumire88
Copy link
Contributor

sumire88 commented Mar 1, 2024

Kernel tests are not passing. Could you take a closer look, please? @MarksonHon

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@MarksonHon MarksonHon merged commit 88d3629 into daeuniverse:main Mar 2, 2024
27 checks passed
@dae-prow dae-prow bot mentioned this pull request Apr 2, 2024
@dae-prow dae-prow bot mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants