fix: Watch sysctl changes to ensure expected values #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A typical process is systemd-sysctl. |
mzz2017
reviewed
Jan 14, 2024
jschwinger233
force-pushed
the
gray/dae0-sysctl
branch
from
5c4aa21 to
78690e9
Compare
mzz2017
reviewed
Jan 22, 2024
|
Almost ready to merge. Thanks for your great work! |
jschwinger233
force-pushed
the
gray/dae0-sysctl
branch
from
78690e9 to
3df979c
Compare
sumire88
previously approved these changes
Jan 22, 2024
mzz2017
previously approved these changes
Jan 23, 2024
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
jschwinger233
dismissed stale reviews from dae-prow[bot], mzz2017, and sumire88
via
4019fb4
jschwinger233
force-pushed
the
gray/dae0-sysctl
branch
from
89585b1 to
4019fb4
Compare
sumire88
approved these changes
Jan 23, 2024
|
I have dae v0.5.1 installed, got: |
|
@douglarek Did you see connectivity issues? If so, did you see warn or error log? |
This info log is printed only when starting the daemon (dae), with no other related warning or error logs. |
|
@douglarek What kind of connectivity issue did you have? |
Not yet. |
|
@douglarek It's an info log, no worries, unless connectivity is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We noticed some process other than dae will change dae0's sysctl and break the connectivity from dae netns.
This PR fixes the issue by inotify watching the sysctl files and ensure expected values are set.
Checklist
Full Changelogs
Issue Reference
This PR proposes some optimization against #414
Test Result