Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add guide to separate configuration files #389

Merged
merged 5 commits into from
Dec 30, 2023
Merged

docs: add guide to separate configuration files #389

merged 5 commits into from
Dec 30, 2023

Conversation

epmtyicu
Copy link
Contributor

@epmtyicu epmtyicu commented Dec 30, 2023 •
edited
Loading

Background

Add docs for separate configuration files.

Checklist

Full Changelogs

  • docs: add guide for separated configuration files

Issue Reference

#42

Discussion

#81 (comment)

Test Result

@epmtyicu epmtyicu requested a review from a team as a code owner December 30, 2023 08:40
@dae-prow dae-prow bot added the documentation Improvements or additions to documentation label Dec 30, 2023
sumire88
sumire88 requested changes Dec 30, 2023
View reviewed changes
docs/en/configuration/separated-config.md Outdated Show resolved Hide resolved
docs/en/configuration/separated-config.md Outdated Show resolved Hide resolved
docs/en/configuration/separated-config.md Outdated Show resolved Hide resolved
docs/en/configuration/separated-config.md Outdated

Config files:

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```jsonc

Copy link
Contributor Author

@epmtyicu epmtyicu Dec 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dae's configuration file is not of JSONC type. So I prefer to leave it empty here.

docs/en/configuration/separated-config.md Outdated
}
```

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```jsonc

docs/en/configuration/separated-config.md Outdated
}
```

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```jsonc

docs/en/configuration/separated-config.md Outdated
}
```

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```jsonc

@epmtyicu epmtyicu changed the title docs: add guide for separated configuration files docs: add guide for separate configuration files Dec 30, 2023
@mzz2017
Copy link
Contributor

mzz2017 commented Dec 30, 2023

Duplicated files?

@sumire88 sumire88 changed the title docs: add guide for separate configuration files docs: add guide to separate configuration files Dec 30, 2023
@epmtyicu
Copy link
Contributor Author

Duplicated files?

My fault

@epmtyicu epmtyicu requested a review from sumire88 December 30, 2023 13:06
@sumire88
Copy link
Contributor

Thanks for your brilliant work. Appreciate the effort.

@sumire88 sumire88 merged commit cab1e42 into daeuniverse:main Dec 30, 2023
1 check passed
@dae-prow dae-prow bot mentioned this pull request Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumire88 sumire88 sumire88 approved these changes

Assignees

@epmtyicu epmtyicu

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epmtyicu @mzz2017 @sumire88