Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/hotfix: demise buildarg=pie #282

Merged
merged 4 commits into from
Aug 14, 2023
Merged

ci/hotfix: demise buildarg=pie #282

merged 4 commits into from
Aug 14, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Aug 14, 2023

Background

Completely demise buildarg=pie.

PRs that introduce breaking changes:

Checklist

Full Changelogs

Source: https://github.com/daeuniverse/dae/pull/270/files#diff-5cb7b4c67b5f118757a39679dac9abd4b38fbbf59b77436071adb6255ddfab7c

Issue Reference

Closes #[issue number]

Test Result

@mzz2017
Copy link
Contributor

mzz2017 commented Aug 14, 2023

DON'T do this. I'll modify the Makefile.

@mzz2017
Copy link
Contributor

mzz2017 commented Aug 14, 2023

Well. After review, I think the reverting is also aceeptable.

@piyoki
Copy link
Contributor Author

piyoki commented Aug 14, 2023

Let's roll it back.

@mzz2017
Copy link
Contributor

mzz2017 commented Aug 14, 2023

Please also fix it in dae-wing. Thank you.

@piyoki piyoki merged commit 5b4f9e0 into main Aug 14, 2023
@piyoki piyoki deleted the demise_pie branch August 14, 2023 11:16
@piyoki
Copy link
Contributor Author

piyoki commented Aug 14, 2023

Please also fix it in dae-wing. Thank you.

Will do in a sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants