Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change default tcp_check_http_method from CONNECT to HEAD #137

Merged
merged 1 commit into from
Jun 11, 2023
Merged

fix: change default tcp_check_http_method from CONNECT to HEAD #137

merged 1 commit into from
Jun 11, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 11, 2023

Background

CONNECT will cause unexpected status code for some domains, like gstatic.com.

The method name is mistaken and should be corrected to HEAD.

Checklist

Full changelog

  • example.dae
  • desc.go
  • config.go

Issue reference

Fix #134

@mzz2017 mzz2017 merged commit 24433d1 into main Jun 11, 2023
@mzz2017 mzz2017 deleted the fix_bad_check_http_method branch June 11, 2023 04:47
@kunish kunish mentioned this pull request Jun 11, 2023
Merged
@piyoki piyoki mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunish kunish kunish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad compatibility of tcp_check_http_method: CONNECT
2 participants
@mzz2017 @kunish