-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Made the usage of if
clauses in authentication & authorization, and error pipelines consistent
#1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be used in a conditional error handler decorator
…he subject aware handlers and one for error handlers
…figuration return now an error on an attmept to do so
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1784 +/- ##
==========================================
- Coverage 89.79% 89.72% -0.08%
==========================================
Files 270 270
Lines 9039 9012 -27
==========================================
- Hits 8117 8086 -31
- Misses 682 685 +3
- Partials 240 241 +1 ☔ View full report in Codecov by Sentry. |
dadrus
changed the title
refactor!: foo
refactor!: Aligned the usage of Sep 13, 2024
if
clauses in authentication & authorization, and error pipelines for consistency
dadrus
changed the title
refactor!: Aligned the usage of
refactor!: Made the usage of Sep 13, 2024
if
clauses in authentication & authorization, and error pipelines for consistencyif
clauses in authentication & authorization, and error pipelines consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #1783
Checklist
Description
As mentioned in #1783, the authentication and authorization pipeline supports the use of an
if
clause at each pipeline step, while the error pipeline does not; instead, theif
clause is part of theerror_handler
definition.This PR addresses that inconsistency, introducing a breaking change. Now, none of the mechanisms in the mechanism catalogue support the
if
clause within their own configurations. Theif
clause is now exclusively used in the definition of a step within a pipeline. For error handlers, this means you must specify the condition under which a particular error handler should be executed in the error pipeline. If no condition is defined, the particular error handler will always execute, and the error pipeline will terminate.The following configuration snippets highlight the changes in detail.
Before this PR
After this PR
The examples above highlight the differences by making use of an error pipeline of a default rule. Same applies to the regular rules.