Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Template Support #4

Merged
merged 1 commit into from
May 1, 2012
Merged

Conversation

nhuray
Copy link

@nhuray nhuray commented Apr 16, 2012

Hi David,

I'd like to submit a pull request regarding the Index Template.

Context

Elasticsearch support index templating.

So IMO spring-elasticsearch should support this feature in the same way as mapping.

Solution

In ElasticsearchAbstractClientFactoryBean class we have to add template support, so templates configuration will be scan in es/_template folder during Bean initialization.

To achieve this feature I had to submit a pull request to Shay (integrated yesterday)

Changelog

  • Upgrade elasticsearch version to 0.19-3-SNAPSHOT to use this feature
  • Rename forceReinit to forceMapping in ElasticsearchAbstractClientFactoryBean
  • Add Test ElasticsearchTemplateTest.java

@dadoonet
Copy link
Owner

Thanks Nicolas for the pull request.
May I ask that you remove the .idea/projectCodeStyle.xml file in your commit as we want to ignore .idea files ?

BTW, I will merge it when Shay will release 0.19.3. So it will be either in 0.0.1 release or 0.0.2.
Is it ok for you ?

Thanks.

@ghost ghost assigned dadoonet Apr 16, 2012
@nhuray
Copy link
Author

nhuray commented Apr 16, 2012

Ok David

  • I remove the .idea/projectCodeStyle.xml file (it's a mistake)
  • We wait for Elasticsearch 0.19.3 release before merge

Regards,

Nicolas

  - Upgrade elasticsearch version to 0.19-3-SNAPSHOT to use this feature elastic/elasticsearch#1860
  - Rename forceReinit to forceMapping in ElasticsearchAbstractClientFactoryBean
  - Add Test ElasticsearchTemplateTest.java
@dadoonet dadoonet merged commit 977478e into dadoonet:master May 1, 2012
@dadoonet
Copy link
Owner

dadoonet commented May 1, 2012

@nhuray Could you please add some documentation about templating in the README file ? It would be useful for upcoming users.
Cheers

@dadoonet
Copy link
Owner

dadoonet commented May 9, 2012

Hi @nhuray

Sorry to nag but did you think you will update the README file to add information about templating ?
Don't worry if you haven't spare time to do it. We could add it later after the first release.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants