Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging rmarkdown branch with master #51

Closed
wants to merge 2 commits into from
Closed

Conversation

xiangnandang
Copy link

merge rmarkdown branch with master to allow further development of the package to support rmarkdown documents with shiny runtime

@daattali
Copy link
Owner

daattali commented Jun 5, 2020

Thanks. That code looks like it was written in a hurry (understandably - Andrew was just writing it as a quick proof of concept), I don't feel comfortable merging it at its state. The code style is poor, I see there's a paramter header_file with a default value but does that default value work? There is no documentation saying how to use this function, and the rmd_in_header function is using the old style of manually adding all the CSS styles in the code (see this refactor).

I don't want to add any bad code into the repository because then it becomes a maintenance liability. If you have some time you can start going through and cleaning this up. When I find time to devote to this package again I can do it too.

@daattali
Copy link
Owner

daattali commented Jun 5, 2020

Related to #8

@xiangnandang
Copy link
Author

thanks, that makes sense. I'll go through and clean up at a slight later time.

@daattali
Copy link
Owner

Hi @xiangnandang would you like to come back to this PR and fix it up?

@daattali
Copy link
Owner

daattali commented Mar 5, 2023

@xiangnandang I want to do some cleanup of old PRs - do you think you'll have time in 2023 to resolve this PR, or should we abandon it?

@daattali
Copy link
Owner

Closing due to inactivity. I'd be happy to accept a PR if someone wants to take this up in the future.

@daattali daattali closed this Apr 12, 2023
@daattali daattali deleted the rmarkdown branch April 18, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants