Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del junk #1328

Closed
wants to merge 51 commits into from
Closed

del junk #1328

wants to merge 51 commits into from

Conversation

devoredevelops
Copy link

@devoredevelops devoredevelops commented Jun 6, 2024

No description provided.

devoredevelops and others added 21 commits September 18, 2019 22:43
* Fix absolute URL generation

url and baseurl config for this theme deviates from jekyll standard,
and that results in double inclusion of project path
if this theme is used as project page.

Switching to Jekyll accepted url usage so that
absolute_url filter works.

* Alternate links need to be aboslute

* mention url and baseurl only need to be modified in local dev

* Update readme on new url/baseurl setting changes
@devoredevelops devoredevelops marked this pull request as ready for review June 6, 2024 12:52
@devoredevelops
Copy link
Author

lgtm

@devoredevelops devoredevelops deleted the del_junk branch June 6, 2024 12:52
@devoredevelops devoredevelops restored the del_junk branch June 6, 2024 12:54
Copy link
Author

@devoredevelops devoredevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/reject

@devoredevelops devoredevelops deleted the del_junk branch June 6, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants