Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitpython version rollback for webui update errors #1036

Closed
wants to merge 1 commit into from
Closed

gitpython version rollback for webui update errors #1036

wants to merge 1 commit into from

Conversation

kreendurron
Copy link

Describe your changes

Users were getting errors attempting to update their extensions in Automatic 1111. See thread: AUTOMATIC1111/stable-diffusion-webui#8281 (comment)

Issue ticket number and link (if applicable)

#982

Checklist before requesting a review

  • This is based on the /dev branch (Or a fork of it)
  • This was created or at least validated using a proper IDE
  • I have tested this code and validated any modified functions
  • I have added the appropriate documentation and hint strings if adding or changing a user-facing feature

Users were getting errors attempting to update their extensions in Automatic 1111.
See thread: AUTOMATIC1111/stable-diffusion-webui#8281 (comment)
@d8ahazard
Copy link
Owner

I mean this in the nicest way...

But I will abso-fucking-lutely not merge this.

To fix the issue, someone needs to get @AUTOMATIC1111 to merge AUTOMATIC1111/stable-diffusion-webui#8118 to his repository.

It's a critical security issue. While it may seem like me being pedantic, I have no desire to ship software that allows full-on remote code execution, especially when it can be used in a public setting. It's dumb, and it's terrible coding practice.

Additionally, this is not created against the /dev branch, which is a requirement for any PRs to make their way into main. Which, again...just my opinion, but allowing people to submit PRs directly against the /main branch is an outright terrible practice.

Not trying to be a grumpy as$ here, but I am prepared to die on this hill. If people want to be upset that things are broken...I'm the wrong person to be upset with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants