Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ATL parsing for better parse errors and more flexibility #216

Merged
merged 42 commits into from
Sep 12, 2023

Conversation

NicEastvillage
Copy link
Contributor

@NicEastvillage NicEastvillage commented Sep 7, 2023

This PR rewrites the ATL parser. Instead of using pom it is now a handmade lexer and parser. This PR is the first step towards #42, #104, #190.

This PR includes the following:

  • Replaces the ATL pom parser with handmade Lexer and Parser.
    • The Lexer and Parser is designed to be able to parse LCGS too in the future.
  • Adds better parsing and semantic analysis errors. See below.
  • Changes disjunction and conjunction in ATL from & and | to && and ||, respectively, to be consistent with LCGS.
  • Removes JSON CSG/ATL query support (Its rarely used anyway).

Example of new error messages:
image

@NicEastvillage NicEastvillage marked this pull request as ready for review September 8, 2023 20:20
@NicEastvillage NicEastvillage added enhancement New feature or request refactoring Rewriting or restructuring of existing features labels Sep 8, 2023
Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NicEastvillage NicEastvillage merged commit d8d0aab into main Sep 12, 2023
10 checks passed
@NicEastvillage NicEastvillage deleted the parse-errors branch September 12, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Rewriting or restructuring of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants