Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long SystemCleaner scan due to /data/rootfs #1331

Closed
zhangweildlh opened this issue Jul 28, 2024 · 2 comments · Fixed by #1334
Closed

Long SystemCleaner scan due to /data/rootfs #1331

zhangweildlh opened this issue Jul 28, 2024 · 2 comments · Fixed by #1334
Labels
c: Exclusions c: SystemCleaner Device specific A device specific issue or behavior. enhancement New feature, request, improvement or optimization

Comments

@zhangweildlh
Copy link

zhangweildlh commented Jul 28, 2024 •
edited
Loading


Describe the bug

  1. Click on 'SystemCleaner'
  2. Stuck in the 'Scanning' phase；Continuous scan, unable to end scan
    
    Expected behavior
    I hope to successfully complete the scan and clean up the 'system junk files'
    
    Smartphone (please complete the following information):
  • Device: [e.g. Pixel 9] Xiaomi Pad 5 Pro
  • OS: [e.g. Android 17] Xiaomi HyperOS 1.0.1.0 ( Android 14)
  • Root status [e.g. Rooted - Magisk v25.2] 27.0(27000)
  • SD Maid 2/SE version [e.g. v0.6.6-rc6] 1.2.1-rc0
    
    Debug log
    debug-log：eu.darken.sdmse_logfile_1722181652032.zip
    eu.darken.sdmse_logfile_1722181652032.zip


Screenshots/Video
Screenshots.zip



@zhangweildlh zhangweildlh added bug Something isn't working as expected triage This ticket needs to be sorted and labeled. labels Jul 28, 2024
@d4rken d4rken added c: SystemCleaner and removed triage This ticket needs to be sorted and labeled. labels Jul 28, 2024
@d4rken
Copy link
Member

d4rken commented Jul 28, 2024

Not stuck, just scanning lots of files in /data/rootfs.

Try creating an exclusion for that path and let me know if it works.

I don't think there is any good reasons for SD Maid to scan that path, no good targets in there, maybe we add a default exclusion 🤔

@d4rken d4rken added api: 34 A14 (Upside Down Cake) and removed bug Something isn't working as expected labels Jul 28, 2024
@d4rken d4rken mentioned this issue Jul 28, 2024
Closed
@d4rken d4rken changed the title “SystemCleaner”has bug Long SystemCleaner scan due to /data/rootfs Jul 28, 2024
@zhangweildlh
Copy link
Author

Not stuck, just scanning lots of files in /data/rootfs.

Try creating an exclusion for that path and let me know if it works.

I don't think there is any good reasons for SD Maid to scan that path, no good targets in there, maybe we add a default exclusion 🤔

“/data/rootfs ”in Xiaomi PAD is a container for PC grade WPS ？？？

@d4rken d4rken added c: Exclusions Device specific A device specific issue or behavior. and removed api: 34 A14 (Upside Down Cake) labels Jul 31, 2024
@d4rken d4rken mentioned this issue Jul 31, 2024
Merged
d4rken added a commit that referenced this issue Jul 31, 2024
@d4rken
SystemCleaner: Add default exclusion for /data/rootfs
098ae87 
This is not a common folder or one that has many (or any?) legit targets.

Edge cases where is desired to be scanned can just remove the default exclusion.

Fixes #1331
@d4rken d4rken added the enhancement New feature, request, improvement or optimization label Jul 31, 2024
@d4rken d4rken mentioned this issue Jul 31, 2024
Merged
d4rken added a commit that referenced this issue Jul 31, 2024
@d4rken
Exclusions: Allow segment exclusions specific to SystemCleaner
abdfe83 
Noticed via #1331
@d4rken d4rken mentioned this issue Jul 31, 2024
Merged
@d4rken d4rken closed this as completed in 6605218 Jul 31, 2024
d4rken added a commit that referenced this issue Jul 31, 2024
@d4rken
Exclusions: Allow segment exclusions specific to SystemCleaner
48633d9 
Noticed via #1331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Exclusions c: SystemCleaner Device specific A device specific issue or behavior. enhancement New feature, request, improvement or optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SystemCleaner: Add default exclusion for /data/rootfs d4rken-org/sdmaid-se
2 participants
@d4rken @zhangweildlh