Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis update: Organize Dockerfile and reduce docker size #447

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Oct 12, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

Update Dockerfile to make it more organized and reduce the size of Docker image by deleting unused packages.

What was your approach?

Update Dockerfile to make it more organized and reduce the size of Docker image by deleting unused packages.

What GitHub issue does your pull request address?

#425

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Dockerfile

Is there anything that you want to discuss further?

Discuss about the analysis modules that are not using in the current OpenPedCan and remove the packages in these modules.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from a team as a code owner October 12, 2023 20:05
Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@jharenza jharenza self-requested a review October 18, 2023 20:22
@devbyaccident devbyaccident force-pushed the zzgeng/Docker_organize branch from 9bf52b4 to bd7eeb7 Compare October 18, 2023 20:27
@jharenza
Copy link
Collaborator

🚀

@jharenza jharenza merged commit 1e9a8f9 into dev Oct 18, 2023
23 checks passed
@jharenza jharenza deleted the zzgeng/Docker_organize branch October 18, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants