-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create methyl array probes annotation module #411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor, but i see there is a typo in script 02 - "interect" should be "intersect".
analyses/methylation-probe-annotations/run-methyl-probe-annotation.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module runs successfully when suggested modifications are made
Thank you, @rjcorb, for reviewing |
Note: this is awaiting updates based on some feedback @afarrel will provide |
From @afarrel via slack:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ewafula! Everything looks good.
Purpose/implementation Section
What scientific question is your analysis addressing?
Create Illumina Infinium Human Methylation array probe annotation based on the Human Build 38 (GRCh38/hg38) and GENCODE v39 release
What was your approach?
Created OPC module for generating methyl probe annotations
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
No
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
tables
What is your summary of the results?
results/infinium.gencode.v39.probe.annotations.bedtools.tsv.gz
results/infinium.gencode.v39.probe.annotations.tsv.gz
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.