-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epsilon3 and intersect(a, b) #3
Comments
A way to get reproducible results and avoid the tests wobbling is to get rid of Math.random() and replace it with a deterministic function like Math.sin( 10000 * xxx). Fix coming soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From Jason Davies's code (ported in 82d9481#diff-1955ba130f17ffd3f1a5db97ee798e02R13 ), there was an epsilon2 test in this function.
Somehow it allowed lines to escape the clipping on some occasions, so I lowered it to epsilon3 in 202e604 and got much less errors.
But it still happens, and the fix is to get rid of any epsilon and compare the values with 0.
I wonder what I'm missing (in which cases this value should be st. positive), but testing in all my examples seems to be OK with 0 instead of epsilon3.
The text was updated successfully, but these errors were encountered: