-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tickSizeOuter(0) not yielding straight line #32
Comments
curran
added a commit
to curran/d3-axis
that referenced
this issue
Mar 30, 2017
curran
added a commit
to curran/d3-axis
that referenced
this issue
Mar 30, 2017
There is this issue on each axis ends. For information : http://jsfiddle.net/7w2phbr6/87/ @curran : I thought to the same kind of fix (related to your previous pull request) 👍. Any new idea ? axis.style('stroke-linecap', 'square');
// http://jsfiddle.net/7w2phbr6/91/
// Not perfect - Use CSS axis.style('stroke-dasharray', '0 0.5 ' + range-size + ' 0.5')
// http://jsfiddle.net/7w2phbr6/108/
// Not perfect - Use CSS No other idea :/ |
Fixed in 1.0.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The README states
However, practically this is not exactly true. When setting a stroke on the
.domain
path, one can observe that the endpoints are not quite right, as in this example:In this case, after setting
tickSizeOuter(0)
, I would expect that the domain path ending would end up as a square end.The path for the X axis domain is
M0.5,0V0.5H867.5V0
. When changing it manually toM0.5,0V0.5H867.5
, the resulting rendered path is a straight line:The solution would be to exclude the
V0
part of the path whentickSizeOuter === 0
somewhere around axis.js#L92. The following bit of implementation would need to change:The change might look something like this:
Is this change something that would be desirable?
The text was updated successfully, but these errors were encountered: