Setup jest #7
Merged
Setup jest #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/badge/__tests__/badge.tsx
Outdated
| @@ -0,0 +1,36 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
Can you rename the file to badge.test.tsx please?
There was a problem hiding this comment.
feel free to do it yourself 👍 (because I am OOO for today ;))
|
@DanielMSchmidt let's not use |
|
@weblancaster I agree with you, although storyshots also uses jest & snapshot testing, just fully automated from your storybook stories 🙈 But yeah, let's improve tooling when we need it |
DanielMSchmidt
force-pushed
the
danielmschmidt/DCOS-21785-jest
branch
from
777e826 to
3f558f8
Compare
|
I also added tshint as pretest step. |
added 2 commits
March 26, 2018 08:51
We can't use story shots because of other plugins we use. Maybe we should take the time to decide if a) this is important to us and b) we can find a way around this Closes DCOS-21785
DanielMSchmidt
force-pushed
the
danielmschmidt/DCOS-21785-jest
branch
from
0df86e9 to
463b998
Compare
weblancaster
approved these changes
Mar 26, 2018
weblancaster
suggested changes
Mar 26, 2018
weblancaster
approved these changes
Mar 26, 2018
weblancaster
force-pushed
the
danielmschmidt/DCOS-21785-jest
branch
from
8428dce to
6f35647
Compare
weblancaster
force-pushed
the
danielmschmidt/DCOS-21785-jest
branch
from
6f35647 to
686c17a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use story shots because of other plugins we use. Maybe we
should take the time to decide if
a) this is important to us and
b) we can find a way around this
Closes DCOS-21785