This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Abstract event manager #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the event_manager abstraction dependency injection. For now: SocketManager -> EventManager -> internal::EventManager. In this step we only virtualized (raised) the mandatory send() functions. internal::EventManager exists to inject only the functions that http_proxy depends on.
…ocketManager derived class). This also tackles the rename of the variable socket_manager -> event_manager.
…bev_event_manager.{h,c}pp
forward all io::* calls into virtual implementations in event_manager.
…nchmark requires a fork before libprocess is initialized. The benchmark uses 2 separate processmanagers in order to prevent short-circuiting of message passing.
…unctions to reduce the interface.
…n enumeration representing what kind of IO should be performed.
|
This pull request is just a friendly environment for comments on this proposed change. |
| extern int __s__; | ||
|
|
||
| // Local IP address. | ||
| extern uint32_t __ip__; |
There was a problem hiding this comment.
So why are we declaring the externs here?
…rk connection differently in different implementations of the EventManager interface.
| { | ||
| cleanup(); | ||
| } | ||
| typedef int id_t; |
| // satisfy HTTP/1.1 pipelining. Each request should either enqueue a | ||
| // response, or ask the proxy to handle a future response. The process | ||
| // is responsible for making sure the responses are sent in the same | ||
| // order as the requests. Note that we use a 'Socket' in order to keep |
There was a problem hiding this comment.
Shouldn't the names here change Socket<>Connection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharing event manager API