This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
[DCOS-60865] Test pod affinity and tolerations support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alembiewski
requested review from
akirillov,
rpalaznik,
farhan5900 and
VladimirKravtsov
akirillov
approved these changes
Nov 15, 2019
| testTolerationWithKeyPresent(t, pod, testLabelName) | ||
| } | ||
|
|
||
| func testAffinityRules(t *testing.T, pod v12.Pod, label string) { |
There was a problem hiding this comment.
I'd suggest aligning the function name with testTolerationWithKeyPresent because testAffinityRules sounds pretty generic while it verifies the presence of a specific label in the rule.
There was a problem hiding this comment.
yes, makes sense, changed
VladimirKravtsov
approved these changes
Nov 16, 2019
alembiewski
force-pushed
the
test-affinity-and-tolerations
branch
from
cec42d7 to
d8e8260
Compare
porridge
added a commit
that referenced
this pull request
Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Resolves DCOS-60865: Test pod affinity and tolerations support
This PR introduces tests for pod affinity rules and tolerations.
Note: tests use new utility methods, that were introduced in #61, this PR will be updated after the aforementioned is merged.
Why are the changes needed?
To verify that affinity and toleration rules, defined in
SparkApplicationproperly propagated to a pod's specification.How were the changes tested?
Tested by running the tests locally on minikube cluster as well as running tests from this repo in CI