Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

[DCOS-60858] [Spark Operator] Test mounting secrets #59

Merged
merged 6 commits into from
Nov 13, 2019

Conversation

farhan5900
Copy link
Contributor

What changes were proposed in this pull request?

Resolves DCOS-60858

Implements integration tests for environment based secret as well as file based secret. It creates a secret and for the case of file based test, it mounts secret as file and check mounted path in job description. For the case of env based test, it set an environment variable by referencing it to a secret key and check for the environment variable in job description.

Why are the changes needed?

To verify File based as well as env based secret working.

How were the changes tested?

Ran make test locally.

Copy link
Contributor

@VladimirKravtsov VladimirKravtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. But one comment I left.

tests/security_test.go Show resolved Hide resolved
Copy link
Contributor

@VladimirKravtsov VladimirKravtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, @farhan5900!

Copy link
Contributor

@rpalaznik rpalaznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just two minor suggestions from me.

tests/security_test.go Outdated Show resolved Hide resolved
tests/security_test.go Outdated Show resolved Hide resolved
@farhan5900 farhan5900 merged commit 2d12a67 into master Nov 13, 2019
@farhan5900 farhan5900 deleted the DCOS-60858-test-mount-secrets branch November 13, 2019 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants