Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

enhance the external access support #64

Merged
merged 3 commits into from
Oct 27, 2020
Merged

enhance the external access support #64

merged 3 commits into from
Oct 27, 2020

Conversation

zmalik
Copy link
Contributor

@zmalik zmalik commented Oct 9, 2020

This PR

  • add support for adding annotations to the external services
  • add support for node internal IP using the parameter EXTERNAL_NODEPORT_IP_TYPE

@zmalik zmalik requested review from ANeumann82 and nfnt October 9, 2020 11:07
@zmalik zmalik requested a review from porridge as a code owner October 9, 2020 11:07
nfnt
nfnt approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ANeumann82
ANeumann82 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfnt nfnt merged commit 5e7e450 into master Oct 27, 2020
@nfnt nfnt deleted the zm/enhance-external branch October 27, 2020 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nfnt nfnt nfnt approved these changes

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@porridge porridge Awaiting requested review from porridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmalik @ANeumann82 @nfnt