Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Switching to kuttl for MWT #138

Merged
merged 9 commits into from
Jun 8, 2020
Merged

Switching to kuttl for MWT #138

merged 9 commits into from
Jun 8, 2020

Conversation

kensipe
Copy link
Contributor

@kensipe kensipe commented Jun 2, 2020

Switch to using KUTTL for MWT

I've tested against a Konvoy cluster with the following changes to the setup/01-cassandra-install/02-install-cassandra.yaml file

  parameters:
    NODE_COUNT: "3"
    NODE_MEM_MIB: "4096"
    NODE_MEM_LIMIT_MIB: "4096"
    NODE_CPU_MC: "1000"
    NODE_CPU_LIMIT_MC: "1000"
    NODE_DISK_SIZE_GIB: "20"

I would be inclined to restructure the folders and README if we can get agreement on this is the way we want to move forward. (I would likely remove or rename mwt folder and merge the 2 README files)

I did discover some weakness in kuttl with this... namely around namespace management... the delete properties for a TestStep do not honor the namespace defined... they only delete what is in the generated test namespace. Which has worked well for tests but isn't great when the focus is setup and verify. Created kudobuilder/kuttl#124 to track.

Signed-off-by: Ken Sipe [email protected]

Copy link
Contributor

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as first automation of install/delete for MWT using KUTTL

benchmarks/mwt/README.md Outdated Show resolved Hide resolved
benchmarks/mwt/setup/00-kudo-check/00-assert.yaml Outdated Show resolved Hide resolved
apiVersion: kuttl.dev/v1beta1
kind: TestStep
commands:
- command: kubectl kudo install cassandra --skip-instance --namespace cassandra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should test from the local path in this case if MWT scripts are living next to operator

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmalik I don't know what you mean

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are referring to using the local build of this operator in this repo... I would rather not... MWT should only be on released operators and the scripts should work against the released operator repo IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would generally agree, although with a project that is heavily in development this might not always be possible. For the last MWT I used a dev-version from master.

I do hope that we have reached a state where this won't be necessary anymore though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually participate with the next unreleased version in MWT to make sure there are no stability issues with the upcoming release under load tests.
that's a non-blocker issue as would require minimal effort to change it when running MWT. Moreover, now given the new dates we will participate with a released version so each time it will heavily dependent on operator release dates and MWT dates

benchmarks/mwt/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, especially for a start. I think using kuttl for certain aspects of MWT has a merit

@kensipe
Copy link
Contributor Author

kensipe commented Jun 5, 2020

after fixing kudo... might want to look at
for 02-install-cassandra.yaml

apiVersion: kuttl.dev/v1beta1
kind: TestStep
commands:
  - command: kubectl kudo install --instance cassandra cassandra --namespace cassandrra  -P params.yaml    

@kensipe
Copy link
Contributor Author

kensipe commented Jun 5, 2020

updated to cassandra 1.0.0 + added test configs

…erator into ken/mwt

� Conflicts:
�	benchmarks/README.md
�	benchmarks/mwt/README.md
�	benchmarks/mwt/setup/01-cassandra-install/02-install-cassandra.yaml
@ANeumann82 ANeumann82 merged commit f77da1c into master Jun 8, 2020
@ANeumann82 ANeumann82 deleted the ken/mwt branch June 8, 2020 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants