Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Add delete strategy to reloader #956

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

armandgrillet
Copy link
Contributor

@armandgrillet armandgrillet commented Mar 9, 2021

What type of PR is this?
Bug

What this PR does/ why we need it:
Trying to fix issue when upgrading KBA: https://mesosphere.slack.com/archives/CLETZF5U6/p1615265348020900

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

When upgrading from a release that used helm 2 to install, reloader cannot be cleanly upgraded due to selector changes. This adds a flag that causes reloader to be uninstalled before being upgraded. This should have no effect on running applications.

Checklist

  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@armandgrillet armandgrillet requested a review from a team as a code owner March 9, 2021 09:01
@d2iq-mergebot
Copy link
Contributor

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

@armandgrillet armandgrillet force-pushed the testing-1.19-3.3.0-rc.1-reloader-delete-strategy branch from 886c4e6 to 4041340 Compare March 9, 2021 09:29
@armandgrillet armandgrillet requested a review from dkoshkin March 9, 2021 16:08
@joejulian
Copy link
Contributor

Rebasing this against master then I'll use the bot to backport.

@joejulian joejulian changed the base branch from release/3.3 to master March 9, 2021 16:59
@joejulian joejulian requested review from a team as code owners March 9, 2021 16:59
@joejulian joejulian force-pushed the testing-1.19-3.3.0-rc.1-reloader-delete-strategy branch from a2c57e1 to 1bc22da Compare March 9, 2021 17:04
@joejulian joejulian changed the title [release/3.3] Add delete strategy to reloader Add delete strategy to reloader Mar 9, 2021
@joejulian joejulian force-pushed the testing-1.19-3.3.0-rc.1-reloader-delete-strategy branch from 1bc22da to 9d65c90 Compare March 9, 2021 17:33
@joejulian joejulian modified the milestones: release/next, release/4.0 Mar 9, 2021
@joejulian
Copy link
Contributor

@mesosphere-mergebot backport release/3 release/3.3

@d2iq-mergebot
Copy link
Contributor

Backport PR for release/3: #957
Conflicts present in files:

addons/reloader/reloader.yaml

Backport PR for release/3.3: #958
Conflicts present in files:

addons/reloader/reloader.yaml

@joejulian joejulian merged commit 4438ca0 into master Mar 9, 2021
@joejulian joejulian deleted the testing-1.19-3.3.0-rc.1-reloader-delete-strategy branch March 9, 2021 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants