-
Notifications
You must be signed in to change notification settings - Fork 21
[release/3][BACKPORT] prometheus: Enable etcd rules #941
Conversation
This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.
|
@mesosphere-mergebot backport release/2 |
in this backport will |
yeah.. I'm not sure backport prs will pass CI 🤔 |
Auto-merging this is blocked due to unsigned mergebot commits, I've raised the issue in https://mesosphere.slack.com/archives/C5U03P5T6/p1615530702043100 |
@joejulian the mergebot commits aren't signed, it might be easier to just open up a new pr and reapply the changes, I'll do that now |
Using #981 instead |
This is a backport of the following PR:
#938
What type of PR is this?
bug
What this PR does/ why we need it:
When I removed mesosphere-specific etcd rules to use the default, I didn't realize the config here needed to be updated to reflect those changes. I tested adding the rule to the daily cluster and verified all the rules look good.
The change was made in v9.3.4, so we need to backport this to konvoy 1.7/1.6/1.5 (release/3.3, release/3.0, release/2.5)
Also, removed some unnecessary configs that have since been added to the chart values as default (mesosphere/charts#969, https://github.com/mesosphere/charts/pull/962/files#diff-4eefbe60d75fc0250847e2e4dfd675f9977d572e6f0b5615b552b8223719a6caR2324)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist